adoroszlai commented on code in PR #5071:
URL: https://github.com/apache/ozone/pull/5071#discussion_r1266893833
##########
hadoop-ozone/dist/src/main/compose/ozone/docker-compose.yaml:
##########
@@ -28,6 +28,7 @@ x-common-config:
x-replication:
&replication
OZONE-SITE.XML_ozone.replication: ${OZONE_REPLICATION_FACTOR:-1}
+ OZONE-SITE.XML_ozone.replication.type: RATIS
Review Comment:
HDDS-9035 turned out to be invalid. On second look, I think we should set
server-side default replication instead of client-side config here:
```suggestion
OZONE-SITE.XML_ozone.server.default.replication:
${OZONE_REPLICATION_FACTOR:-1}
```
This new property was introduced for HDDS-5293. I think that PR should have
updated the docker compose definitions, too.
We can make the same change in all `docker-config` and `docker-compose.yaml`
files, see
https://github.com/adoroszlai/hadoop-ozone/commit/12cda5bd862d7b0eb38f2f08277cd029288b3ba5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
