hemantk-12 opened a new pull request, #5087: URL: https://github.com/apache/ozone/pull/5087
## What changes were proposed in this pull request? This change addresses few of the concerns raised in PR #5061. * Added check to allow only Ozone admin user to call print compaction dag API. * Update the response message stating the file name, parent dir's absolute path and the OM leader node info. Note: This PR doesn't addressed `Having a network call that generates a file on the server is strange.` because of following reason. As we talked in [here](https://github.com/apache/ozone/pull/5061#issuecomment-1638972143), it is better to be have it as a OM request to get the in-memory picture of the DAG. It can be solved in following two ways. 1. Return graph POJO to client and generate the image on client side. But it comes with a problem of graph size and might need pagination. 2. Stream the generated image to the client. But we don't have existed interface to stream a file. Both the solution will require more time and investigation. So for the interest of time, just addressed the security and debug message for now and create a jira: [HDDS-9040](https://issues.apache.org/jira/browse/HDDS-9040) for further enhancement. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-8961 ## How was this patch tested? Existed unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
