smengcl commented on code in PR #5087:
URL: https://github.com/apache/ozone/pull/5087#discussion_r1267464028
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -1547,17 +1547,16 @@ public BootstrapStateHandler.Lock
getBootstrapStateLock() {
return lock;
}
- public String pngPrintMutableGraph(String fileName, GraphType graphType)
+ public void pngPrintMutableGraph(String filePath, GraphType graphType)
throws IOException {
- Objects.requireNonNull(fileName, "Image file name is required.");
+ Objects.requireNonNull(filePath, "Image file path is required.");
Objects.requireNonNull(graphType, "Graph type is required.");
PrintableGraph graph;
synchronized (this) {
- graph = new PrintableGraph(forwardCompactionDAG, graphType);
+ graph = new PrintableGraph(backwardCompactionDAG, graphType);
Review Comment:
Why the switch? Or should we just print both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
