GeorgeJahad commented on code in PR #5070:
URL: https://github.com/apache/ozone/pull/5070#discussion_r1267551829
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -588,6 +590,8 @@ public void onCompactionCompleted(RocksDB db,
return;
}
+ waitForTarballCreation();
Review Comment:
https://github.com/facebook/rocksdb/wiki/RocksDB-Overview#avoiding-stalls
This indicates that compaction threads are also used for flushing memtables,
and if they get backed up, writes will stall, (which is what I've been afraid
of.)
It also indicates that you can workaround the issue by configuring a
dedicated flush threadpool. But I still trying to think of a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
