GeorgeJahad commented on code in PR #5070:
URL: https://github.com/apache/ozone/pull/5070#discussion_r1268840301
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -588,6 +590,8 @@ public void onCompactionCompleted(RocksDB db,
return;
}
+ waitForTarballCreation();
Review Comment:
I like the idea of copying the compaction logs and hard linking the
compaction backup data.
I'm just not convinced we need a checkpoint listener. After thinking about
it and talking to @prashantpogde , I think the compaction listener is the right
place. I just think we are pausing for too long.
Right now, we pause until the network transfer to the follower completes.
That seems dangerously long. But waiting long enough to copy the compaction
logs, make the backup hard links, and do the checkpoint, seems reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
