adoroszlai commented on code in PR #5084:
URL: https://github.com/apache/ozone/pull/5084#discussion_r1270340264
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableECContainerProvider.java:
##########
@@ -159,13 +160,21 @@ public ContainerInfo getContainer(final long size,
// If we get here, all the pipelines we tried were no good. So try to
// allocate a new one.
try {
- synchronized (this) {
- if (openPipelineCount < maximumPipelines) {
+ if (openPipelineCount >= maximumPipelines) {
+ final int nodeCount = nodeManager.getNodeCount(null, null);
+ if (nodeCount > maximumPipelines) {
+ LOG.debug("Increasing pipeline limit {} -> {} for final attempt",
+ maximumPipelines, nodeCount);
Review Comment:
The setting is not changed, increase applies only to this specific
allocation attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
