GeorgeJahad commented on code in PR #5104:
URL: https://github.com/apache/ozone/pull/5104#discussion_r1271372832
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -507,6 +507,7 @@ public void onCompactionBegin(RocksDB db,
}
}
+ waitForTarballCreation();
Review Comment:
I'm ok with changing it back, but we have to be clear about the purpose of
creating the links to the sst files.
If the reason for that is not to allow any extra of these sst files to
appear on the follower then we need to wait here until the links are created.
If we just want to reduce the number, without caring about perfect accuracy,
then we can remove it.
I'm ok either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
