prashantpogde commented on PR #5104: URL: https://github.com/apache/ozone/pull/5104#issuecomment-1648943734
>> In the previous PR the waitForTarballCreation() was only called from the onCompactionComplete listener. Since the sst >> files are backed up in the onCompactionBegin() listener I added a waitForTarballCreation() there as well You don't have to waitForTarballCreation() in onCompactionBegin() listner. It would unnecessary pause the compaction processing which could very well go in parallel. Note that we will anyway stop the final compaction step of updating manifest in onCompactionEnd(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
