hemantk-12 commented on code in PR #5119:
URL: https://github.com/apache/ozone/pull/5119#discussion_r1274591581
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeySetTimesRequestWithFSO.java:
##########
@@ -96,6 +97,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
throw new OMException("Key not found. Key:" + key, KEY_NOT_FOUND);
}
omKeyInfo = keyStatus.getKeyInfo();
+ // HDDS-setting Key name back to Ozone Key before updating cache value.
+ omKeyInfo.setKeyName(OzoneFSUtils.getFileName(key));
Review Comment:
Good find.
1. Should we use helper function defined in `OMFileRequest` and used at
other places. Similar to
https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java#L508
2. Can you please add unit test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
