jojochuang commented on code in PR #5119:
URL: https://github.com/apache/ozone/pull/5119#discussion_r1275345337


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java:
##########
@@ -286,4 +292,35 @@ public void testLeaseRecoverable() throws Exception {
     assertTrue(fs.recoverLease(source));
     assertTrue(fs.isFileClosed(source));
   }
+
+  @Test

Review Comment:
   This is fine. But you can also make the same unit test in 
TestOMKeySetTimesRequestWithFSO.java which is more lightweight (doesn't need to 
deal the entire cluster, client interactions just need to test 
OMKeySetTimesRequestWithFSO )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to