tanvipenumudy commented on code in PR #5115:
URL: https://github.com/apache/ozone/pull/5115#discussion_r1279139626


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1072,6 +1074,19 @@ message KeyInfo {
     optional bool isFile = 19;
 }
 
+message BasicKeyInfo {
+    required string volumeName = 1;
+    required string bucketName = 2;
+    required string keyName = 3;
+    required uint64 dataSize = 4;
+    required uint64 creationTime = 5;
+    required uint64 modificationTime = 6;
+    required hadoop.hdds.ReplicationType type = 7;
+    optional hadoop.hdds.ReplicationFactor factor = 8;
+    optional hadoop.hdds.ECReplicationConfig ecReplicationConfig = 9;
+    optional bool isFile = 10;

Review Comment:
   Thank you @hemantk-12, this is a good idea. I have incorporated the changes 
to remove the field `isFile` from the `BasicKeyInfo` proto message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to