kerneltime commented on code in PR #5115:
URL: https://github.com/apache/ozone/pull/5115#discussion_r1298010531
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1072,6 +1074,16 @@ message KeyInfo {
optional bool isFile = 19;
}
+message BasicKeyInfo {
+ required string keyName = 1;
+ required uint64 dataSize = 2;
+ required uint64 creationTime = 3;
+ required uint64 modificationTime = 4;
+ required hadoop.hdds.ReplicationType type = 5;
Review Comment:
It's best to ways make these optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
