ashishkumar50 commented on code in PR #5099:
URL: https://github.com/apache/ozone/pull/5099#discussion_r1286679183
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/TopologySubcommand.java:
##########
@@ -180,7 +204,32 @@ private String getAdditionNodeOutput(HddsProtos.Node node)
{
// Format "ipAddress(hostName):PortName1=PortValue1 OperationalState
// networkLocation
- private void printNodesWithLocation(Collection<HddsProtos.Node> nodes) {
+ private void printNodesWithLocation(Collection<HddsProtos.Node> nodes,
+ String state) throws IOException {
+ if (json && fullInfo) {
Review Comment:
Please change like below:
```
if (json) {
if (fullInfo) {
.........
return;
}
.......... // without fullInfo handling
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
