hemantk-12 commented on code in PR #5099:
URL: https://github.com/apache/ozone/pull/5099#discussion_r1287499376
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/TopologySubcommand.java:
##########
@@ -136,10 +144,11 @@ public Class<?> getParentType() {
// Format
// Location: rack1
// ipAddress(hostName) OperationalState
- private void printOrderedByLocation(List<HddsProtos.Node> nodes) {
+ private void printOrderedByLocation(List<HddsProtos.Node> nodes,
+ String state) throws IOException {
HashMap<String, TreeSet<DatanodeDetails>> tree =
Review Comment:
nit: interface over implementation.
```suggestion
Map<String, TreeSet<DatanodeDetails>> tree = new HashMap<>();
Map<DatanodeDetails, HddsProtos.NodeOperationalState> operationalState =
new HashMap<>();
```
##########
hadoop-ozone/dist/src/main/smoketest/admincli/printTopology.robot:
##########
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation Test ozone admin printTopology command
+Library OperatingSystem
+Library BuiltIn
+Resource ../commonlib.robot
+Test Timeout 5 minutes
+
+
+*** Test Cases ***
+Run printTopology
+ ${output} = Execute ozone admin printTopology
+ Should Match Regexp ${output} State =
+
+Run printTopology as JSON
+ ${output} = Execute ozone admin printTopology --json
+ ${keys} = Execute echo '${output}' | jq -r '.[0] |
keys'
+ Should Contain ${output} ipAddress
Review Comment:
I think it is missing a new line at the end of the file. If yes, please add
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
