swamirishi commented on code in PR #5155:
URL: https://github.com/apache/ozone/pull/5155#discussion_r1287507470
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -564,6 +569,14 @@ public void submitRequest(OMRequest omRequest) {
}
}
+ public static boolean shouldIgnoreSnapshot(SnapshotInfo snapInfo,
+ SnapshotInfo.SnapshotStatus snapshotStatus,
+ boolean isSstFilteringServiceEnabled) {
+ return !snapshotStatus.equals(
+ SnapshotInfo.SnapshotStatus.SNAPSHOT_DELETED)
+ || (isSstFilteringServiceEnabled && !snapInfo.isSstFiltered());
Review Comment:
We could land in a race condition where the rocksDB will be open by
SSTFilteringService and the OmSnapshotPurgeResponse could delete the checkpoint
directory. It would be better to work with only closed rocksdb instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
