sadanand48 commented on PR #5155: URL: https://github.com/apache/ozone/pull/5155#issuecomment-1670114365
Thanks @hemantk-12 > I don't understand how this is causing OM to go into unhealthy state. We just log [the exception](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java#L202). Yeah, I guess the problem is that it is running the task periodically and failing to process this snapshot in a loop due to which OM gets busy. The exact error in this case was the failure to load a deleted snapshot which is fixed now via this patch with skipActiveCheck=true > I see that there is a problem with the while loop. We should catch exception for individual snapshots and just fail for that particular snapshot otherwise it will block rest of the snapshots SST clean up on-words. Actually inside the while loop it does iterator.next() so it won't process the same snapshot in the next iteration however it might run in the next time interval of the Filtering task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
