errose28 commented on PR #5124: URL: https://github.com/apache/ozone/pull/5124#issuecomment-1679764732
Hi @mladjan-gadzic. @kerneltime and I had some offline discussion about these changes and this is what we found: 1. It looks like Ozone did not actually implement multi chunk signature support in HDDS-693 (5 years ago), only "initial support" to quote the jira. I don't see any code verifying these signatures, just skipping over them. 2. Based on the [AWS docs](https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html) it looks like we can check the `x-amz-decoded-content-length` header to get the length of the data excluding the signature. The length that was being checked previously came from the `Content-Length` header. 3. Going forward we probably need a design doc and parent jira for s3a over FSO. What we are aiming to accomplish is for these two streams of communication to produce identical results: 1. FS client <-> S3a <-> s3 gateway <-> FSO bucket 2. FS client <-> FSO bucket - This requirement to make the s3 gateway "transparent" will require some more planning like Ritesh mentioned instead of just ad-hoc patches as issues arise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
