[ 
https://issues.apache.org/jira/browse/HDDS-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755146#comment-17755146
 ] 

Uma Maheswara Rao G commented on HDDS-731:
------------------------------------------

[~erose] or [~adoroszlai] I think we are having UncaughtExceptionhandlers


{code}
stateMachineThread = new ThreadFactoryBuilder()
.setDaemon(true)
.setNameFormat("Datanode State Machine Daemon Thread")
.setUncaughtExceptionHandler((Thread t, Throwable ex) -> {
String message = "Terminate Datanode, encounter uncaught exception"
+ " in Datanode State Machine Thread";
ExitUtils.terminate(1, message, ex, LOG);
})
.build().newThread(startStateMachineTask);
stateMachineThread.start();
{code}
The above patch proposed to attempt stop on hook trigger. This is quite old 
issue and I don't think we are seeing issues. Please check if we need to add 
stop call on UncaughtException handler. Currently it is calling 
ExitUtils.terminate

> Add shutdown hook to shutdown XceiverServerRatis on daemon stop
> ---------------------------------------------------------------
>
>                 Key: HDDS-731
>                 URL: https://issues.apache.org/jira/browse/HDDS-731
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: Ozone Datanode
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Major
>         Attachments: HDDS-731.001.patch
>
>
> Currently on shutting down a Ozone datanode using "ozone --daemon stop 
> datanode", the XceiverServerRatis is not shutdown properly. This jira 
> proposes to add a shutdownHook to take ratis snapshot on shutdown



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to