[
https://issues.apache.org/jira/browse/HDDS-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756140#comment-17756140
]
Ethan Rose commented on HDDS-731:
---------------------------------
It looks to me like this jira is already covered in the current code.
The proposed patch is making sure the volume usage is saved on shutdown. In the
current code, the datanode shutdown hook is set up in
{{{}HddsDatanodeService#call{}}}. On shutdown this will trigger the following
chain of calls to save volume usage info: {{DatanodeStateMachine#stopDaemon}}
-> {{DatanodeStateMachine#close}} -> {{OzoneContainer#stop}} ->
{{HddsVolume#shutdown}} -> {{{}HddsVolume#shutdownUsageThread{}}}.
The description says that {{XceiverServerRatis}} is not shutdown properly. This
is not the case currently. On the same path as above we have
{{DatanodeStateMachine#stopDaemon}} -> {{DatanodeStateMachine#close}} ->
{{OzoneContainer#stop}} -> {{{}XceiverServerRatis#stop{}}}.
{quote}This jira proposes to add a shutdownHook to take ratis snapshot on
shutdown
{quote}
I'm not sure why this would be necessary. We haven't had this in the current
code for 5 years and it is not in the submitted patch.
> Add shutdown hook to shutdown XceiverServerRatis on daemon stop
> ---------------------------------------------------------------
>
> Key: HDDS-731
> URL: https://issues.apache.org/jira/browse/HDDS-731
> Project: Apache Ozone
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Attachments: HDDS-731.001.patch
>
>
> Currently on shutting down a Ozone datanode using "ozone --daemon stop
> datanode", the XceiverServerRatis is not shutdown properly. This jira
> proposes to add a shutdownHook to take ratis snapshot on shutdown
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
