duongkame commented on code in PR #5225:
URL: https://github.com/apache/ozone/pull/5225#discussion_r1317889633
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopFsGenerator.java:
##########
@@ -63,6 +63,12 @@ public class HadoopFsGenerator extends BaseFreonGenerator
defaultValue = "4096")
private int copyBufferSize;
+ @Option(names = {"-sync"},
+ description = "Type of operation to execute after a write. Supported " +
+ "options include none (default), hflush and hsync",
+ defaultValue = "none")
+ private String flushOrSync;
Review Comment:
Think Option works with enum types, e.g.
https://github.com/apache/ozone/blob/master/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ListSubcommand.java#L72-L74
Exposing `SyncOptions` as a top-level type and using it directly here looks
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
