adoroszlai commented on code in PR #5225:
URL: https://github.com/apache/ozone/pull/5225#discussion_r1339630455
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/HadoopFsGenerator.java:
##########
@@ -63,6 +63,12 @@ public class HadoopFsGenerator extends BaseFreonGenerator
defaultValue = "4096")
private int copyBufferSize;
+ @Option(names = {"--sync"},
+ description = "Type of operation to execute after a write. Supported " +
+ "options include NONE (default), HFLUSH and HSYNC",
+ defaultValue = "none")
Review Comment:
```suggestion
defaultValue = "NONE")
```
`none` gives error if the option is omitted:
```
$ ozone freon dfsg --path ofs://om/vol1/buck1/dir1 -s 1024 -t1 -n1
...
Invalid value for option '--sync': expected one of [NONE, HFLUSH, HSYNC]
(case-sensitive) but was 'none'
```
Sorry, I haven't noticed this earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
