hemantk-12 commented on code in PR #5303:
URL: https://github.com/apache/ozone/pull/5303#discussion_r1329361908
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -479,4 +479,19 @@ message DeletedBlocksTransactionInfo {
optional int64 containerID = 2;
repeated int64 localID = 3;
optional int32 count = 4;
-}
\ No newline at end of file
+}
+
+message CompactionFileInfoProto {
+ required string fileName = 1;
+ optional string startKey = 2;
+ optional string endKey = 3;
+ optional string columnFamily = 4;
+}
+
+message CompactionLogEntryProto {
+ required uint64 dbSequenceNumber = 1;
Review Comment:
I wasn't aware that `required` has been removed from proto3. The only reason
I used `required` to show that a field is mandatory. I don't get why they think
"It is nearly impossible to safely change a field from required to optional".
To me, it should be OK to change required to optional but not vice-versa.
Since it is suggested that required fields should be implemented at the
application layer instead, I will change it to optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
