hemantk-12 commented on code in PR #5303: URL: https://github.com/apache/ozone/pull/5303#discussion_r1329133127
########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionFileInfo.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ozone.compaction.log; + +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.util.Preconditions; + +/** + * Dao to keep SST file information in the compaction log. + */ +public final class CompactionFileInfo { + private final String fileName; + private final String startKey; + private final String endKey; + private final String columnFamily; + + private CompactionFileInfo(String fileName, + String startRange, + String endRange, + String columnFamily) { + this.fileName = fileName; + this.startKey = startRange; + this.endKey = endRange; + this.columnFamily = columnFamily; + } + + public String getFileName() { + return fileName; + } + + public String getStartKey() { + return startKey; + } + + public String getEndKey() { + return endKey; + } + + public String getColumnFamily() { + return columnFamily; + } + + public HddsProtos.CompactionFileInfoProto getProtobuf() { + HddsProtos.CompactionFileInfoProto.Builder builder = + HddsProtos.CompactionFileInfoProto.newBuilder() + .setFileName(fileName); + if (startKey != null) { + builder = builder.setStartKey(startKey); + } + if (endKey != null) { + builder = builder.setStartKey(endKey); Review Comment: Thanks for catching. Updated. ########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionFileInfo.java: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ozone.compaction.log; + +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.util.Preconditions; + +/** + * Dao to keep SST file information in the compaction log. + */ +public final class CompactionFileInfo { + private final String fileName; + private final String startKey; + private final String endKey; + private final String columnFamily; + + private CompactionFileInfo(String fileName, + String startRange, + String endRange, + String columnFamily) { + this.fileName = fileName; + this.startKey = startRange; + this.endKey = endRange; + this.columnFamily = columnFamily; + } + + public String getFileName() { + return fileName; + } + + public String getStartKey() { + return startKey; + } + + public String getEndKey() { + return endKey; + } + + public String getColumnFamily() { + return columnFamily; + } + + public HddsProtos.CompactionFileInfoProto getProtobuf() { + HddsProtos.CompactionFileInfoProto.Builder builder = + HddsProtos.CompactionFileInfoProto.newBuilder() + .setFileName(fileName); + if (startKey != null) { + builder = builder.setStartKey(startKey); + } + if (endKey != null) { + builder = builder.setStartKey(endKey); + } + if (columnFamily != null) { + builder = builder.setStartKey(columnFamily); Review Comment: Thanks for catching. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
