xichen01 commented on code in PR #4798:
URL: https://github.com/apache/ozone/pull/4798#discussion_r1333200286
##########
hadoop-hdds/docs/content/feature/Reconfigurability.md:
##########
@@ -38,13 +38,18 @@ The meaning of command options:
- **status**: Check reconfig status
- **properties**: List reconfigurable properties
-## OM Reconfigurability
+## Retrieve the reconfigurable properties list
+To retrieve all the reconfigurable properties list for a specific component in
Ozone,
+you can use the command: `ozone admin reconfig properties --address=<ip:port>`.
Review Comment:
Already corrected
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/conf/OzoneConfiguration.java:
##########
@@ -335,4 +334,5 @@ private static void addDeprecatedKeys() {
OZONE_CONTAINER_COPY_WORKDIR)
});
}
+
Review Comment:
Done.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4704,6 +4707,14 @@ private String reconfOzoneReadOnlyAdmins(String newVal) {
return String.valueOf(newVal);
}
+ private String reconfOzoneKeyDeletingLimitPerTask(String newVal) {
+ getConfiguration().set(OZONE_KEY_DELETING_LIMIT_PER_TASK, newVal);
Review Comment:
I think may we can provide a `conf.getUnsignedInt()` for those
configurations which must be larger than 0. we can do some check in
`conf.getUnsignedInt()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
