xichen01 commented on code in PR #4798:
URL: https://github.com/apache/ozone/pull/4798#discussion_r1335749216
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -137,7 +146,7 @@ public class DatanodeConfiguration {
* missed. With max threads 5, optimistically DN can handle 1500 individual
* container delete tx in 60s with RocksDB cache miss.
*/
- @Config(key = "block.delete.threads.max",
+ @Config(key = BLOCK_DELETE_THREAD_MAX,
Review Comment:
Yes, if you set the "reconfigurable = true" attribute, the configuration
will be auto handled when "reconfigure".
but one point needs to notice:
The object registered to `ReconfigurationHandler` must be the same conf as
the one that wants to get the value after reconfiguring.
such as:
```java
DatanodeConfiguration dnConf1 =
conf.getObject(DatanodeConfiguration.class)
DatanodeConfiguration dnConf2 =
conf.getObject(DatanodeConfiguration.class)
reconfigurationHandler =
new ReconfigurationHandler("DN", conf, this::checkAdminPrivilege)
.register(dnConf1);
```
After reconfiguring, only `dnConf1 ` can get the changed value, because only
`dnConf1` was registered to the `ReconfigurationHandler`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
