LZD-PratyushBhatt commented on code in PR #5340:
URL: https://github.com/apache/ozone/pull/5340#discussion_r1333842897


##########
hadoop-ozone/dist/src/main/smoketest/omha/om-fetch-key.robot:
##########
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation       Smoke test for om fetch-key
+Library             OperatingSystem
+Resource            ../commonlib.robot
+Test Timeout        5 minute
+Test Setup          Run Keyword if    '${SECURITY_ENABLED}' == 'true'    Kinit 
test user     testuser     testuser.keytab
+
+
+*** Variables ***
+
+
+*** Keywords ***
+
+
+*** Test Cases ***
+Test OM Fetch-Key with OM Service ID
+    ${result} =              Execute                        ozone admin om 
fetch-key --service-id=omservice
+    Should Contain           ${result}                      Current Secret Key 
ID
+    ${result} =              Execute                        ozone admin 
--set=ozone.om.service.ids=omservice,omservice2 om fetch-key 
--service-id=omservice
+    Should Contain           ${result}                      Current Secret Key 
ID
+    ${result} =              Execute And Ignore Error       ozone admin 
--set=ozone.om.service.ids=omservice,omservice2 om fetch-key 
--service-id=omservice3
+    Should Contain           ${result}                      Service ID 
specified does not match
+    ${result} =              Execute And Ignore Error       ozone admin 
--set=ozone.om.service.ids=omservice,omservice2 om fetch-key 
--service-id=omservice2
+    Should Contain           ${result}                      Could not find any 
configured addresses for OM.
+
+Test OM Fetch-Key without OM Service ID
+    ${result} =              Execute                        ozone admin om 
fetch-key
+    Should Contain           ${result}                      Current Secret Key 
ID
+    ${result} =              Execute And Ignore Error       ozone admin 
--set=ozone.om.service.ids=omservice,ozone1 om fetch-key
+    Should Contain           ${result}                      no Ozone Manager 
service ID specified

Review Comment:
   Hi @adoroszlai , updated the PR with the same.
   
   `Om-Fetch-Key :: Smoke test for om fetch-key                                 
  
   
==============================================================================
   Fetch Key with Valid ServiceID Specified                              | PASS 
|
   
------------------------------------------------------------------------------
   Fetch Key with Multiple ServiceIDs, Valid ServiceID Specified         | PASS 
|
   
------------------------------------------------------------------------------
   Fetch Key with Multiple ServiceIDs, Unconfigured ServiceID Specified  | PASS 
|
   
------------------------------------------------------------------------------
   Fetch Key with Multiple ServiceIDs, Invalid ServiceID Specified       | PASS 
|
   
------------------------------------------------------------------------------
   Fetch Key without OM Service ID                                       | PASS 
|
   
------------------------------------------------------------------------------
   Fetch Key with Multiple ServiceIDs, No ServiceID Specified            | PASS 
|
   
------------------------------------------------------------------------------
   Om-Fetch-Key :: Smoke test for om fetch-key                           | PASS 
|
   6 tests, 6 passed, 0 failed
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to