LZD-PratyushBhatt commented on PR #5340: URL: https://github.com/apache/ozone/pull/5340#issuecomment-1731322952
> Thanks @LZD-PratyushBhatt for splitting the tests. > > I've just noticed that these new test cases are not included in any of the test runs. The directory `omha` contains tests for OM HA, some of which are specific to upgrade and/or change from single OM to OM HA. Therefore `omha` is not run as a complete "suite", rather individual Robot files are run explicitly, e.g.: > > https://github.com/apache/ozone/blob/8276aad6d0d8deed192b79285816196acc9a69a0/hadoop-ozone/dist/src/main/compose/ozone-om-prepare/test.sh#L46-L54 > > I think this new test file belongs to the `admincli` directory instead. Moving `om-fetch-key.robot` there would get it executed in several environments. However, `fetch-key` only works in secure cluster, and some of the new test cases only work in HA. So we would need to make changes to skip them unsecure and/or non-HA runs. This can be done in a follow-up task. For now let's keep it in `omha` and add test execution in secure HA cluster by inserting: > > ``` > execute_robot_test s3g omha/om-fetch-key.robot > ``` > > here: > > https://github.com/apache/ozone/blob/8276aad6d0d8deed192b79285816196acc9a69a0/hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test.sh#L53-L55 > > BTW, the same applies to `om-roles.robot`, but it turns out some of those test cases are failing. Filed [HDDS-9341](https://issues.apache.org/jira/browse/HDDS-9341) for that. Hi @adoroszlai , updated the PR, can you please take a look now, Passing in my fork: https://github.com/LZD-PratyushBhatt/ozone/actions/runs/6272987066/job/17036276994?pr=4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
