hemantk-12 commented on code in PR #5317: URL: https://github.com/apache/ozone/pull/5317#discussion_r1337985715
########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java: ########## @@ -116,16 +122,6 @@ public class RocksDBCheckpointDiffer implements AutoCloseable, private final String compactionLogDir; - /** - * Compaction log path for DB compaction history persistence. - * This is the source of truth for in-memory SST DAG reconstruction upon - * OM restarts. - * <p> - * Initialized to the latest sequence number on OM startup. The log also rolls - * over (gets appended to a new file) whenever an Ozone snapshot is taken. - */ - private volatile String currentCompactionLogPath = null; Review Comment: We can't because we need to read exiting compaction log files for backward compatibility. I'll double check if there are more things we can clean up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
