hemantk-12 commented on code in PR #5317:
URL: https://github.com/apache/ozone/pull/5317#discussion_r1343477985
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -740,20 +686,20 @@ public HashSet<String>
readRocksDBLiveFiles(ManagedRocksDB rocksDB) {
}
/**
- * Process each line of compaction log text file input and populate the DAG.
+ * Process log line of compaction log text file input and populate the DAG.
+ * It also adds the compaction log entry to compaction log table.
*/
void processCompactionLogLine(String line) {
LOG.debug("Processing line: {}", line);
synchronized (this) {
- if (line.startsWith("#")) {
- // Skip comments
- LOG.debug("Comment line, skipped");
+ if (line.startsWith(COMPACTION_LOG_COMMENT_LINE_PREFIX)) {
+ reconstructionCompactionReason =
+ line.substring(COMPACTION_LOG_COMMENT_LINE_PREFIX.length());
} else if (line.startsWith(COMPACTION_LOG_SEQ_NUM_LINE_PREFIX)) {
- SnapshotLogInfo snapshotLogInfo = getSnapshotLogInfo(line);
- reconstructionSnapshotGeneration =
snapshotLogInfo.snapshotGenerationId;
- reconstructionLastSnapshotID = snapshotLogInfo.snapshotId;
+ reconstructionSnapshotCreationTime =
+ getSnapshotCreationTimeFromLogLing(line);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
