adoroszlai opened a new pull request, #5396:
URL: https://github.com/apache/ozone/pull/5396

   ## What changes were proposed in this pull request?
   
   `MiniOzoneCluster` logs are difficult to follow because multiple instances 
of the same component use the same name for their own threads (e.g. all SCMs 
have `ReplicationMonitor` thread, etc.).  This can be improved by adding a 
prefix shared between threads of the same instance of a component.
   
   This PR is the first in a series of changes working towards that goal.  It 
adds the ability to specify a prefix for threads created in common/framework 
code (`EventQueue`, `BackgroundService`, etc.).  These are used by multiple 
component types (SCM, OM, DN), but this PR sets the actual prefix only for some 
of the usages as a proof of concept.  Follow-up tasks for each component will 
add the prefix for the remaining usages, as well as other threads created in 
component-specific code (e.g. the `ReplicationManager` threads mentioned 
earlier).
   
   https://issues.apache.org/jira/browse/HDDS-9334
   
   ## How was this patch tested?
   
   Ran some integration tests locally, checked logs for thread names.  Examples:
   
   OM
   
   ```
   [omNode-1-KeyDeletingService#0]
   [omNode-1-SnapshotDeletingService#0]
   [omNode-2-KeyDeletingService#0]
   [omNode-2-SnapshotDeletingService#0]
   [omNode-3-KeyDeletingService#0]
   [omNode-3-SnapshotDeletingService#0]
   ```
   
   SCM
   
   ```
   
[21a4cc26-8e06-44ed-96ba-fe1f5866bc98-EventQueue-PipelineReportForPipelineReportHandler]
   [21a4cc26-8e06-44ed-96ba-fe1f5866bc98-LeaseManager#LeaseMonitor]
   [21a4cc26-8e06-44ed-96ba-fe1f5866bc98-SCMBlockDeletingService#0]
   
[37389ba4-1458-4393-ad14-d634f01278a7-EventQueue-PipelineReportForPipelineReportHandler]
   [37389ba4-1458-4393-ad14-d634f01278a7-LeaseManager#LeaseMonitor]
   [37389ba4-1458-4393-ad14-d634f01278a7-SCMBlockDeletingService#0]
   ```
   
   CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/6422151952


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to