adoroszlai commented on code in PR #5396:
URL: https://github.com/apache/ozone/pull/5396#discussion_r1360114038
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/lease/LeaseManager.java:
##########
@@ -63,19 +63,19 @@ public class LeaseManager<T> {
* Default timeout in milliseconds to be used for lease creation.
*/
public LeaseManager(String name, long defaultTimeout) {
- this.name = name;
+ this.name = name + "LeaseManager";
Review Comment:
`name` in `name + "LeaseManager"` comes from the SCM-specific prefix. Which
means it has the node info, and it ends in `-`. So `this.name` ends up like
`scmNode-1-LeaseManager`. The monitor thread is then named
`scmNode-1-LeaseManager#LeaseMonitor`.
SCM used to pass `"Lease Manager"` as `name` when creating `LeaseManager`:
https://github.com/apache/ozone/blob/f42a2e52db1c100f0700504dcd084c02c86ecbc2/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L657
but that is being changed in this PR:
https://github.com/apache/ozone/blob/963a78b0256be321a6df614b52f0f7b4922c0621/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
