ChenSammi commented on code in PR #5163:
URL: https://github.com/apache/ozone/pull/5163#discussion_r1361523193
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/utils/CertificateSignRequest.java:
##########
@@ -73,8 +73,11 @@
* PKCS10CertificationRequest to CertificateServer.
*/
public final class CertificateSignRequest {
- // Ozone Certificate distinguished format: (CN=Subject,OU=ScmID,O=ClusterID).
+ // Ozone Certificate distinguished format:
+ // (CN=Subject,OU=ScmID,O=ClusterID,SERIALNUMBER=SerialID).
private static final String DISTINGUISHED_NAME_FORMAT = "CN=%s,OU=%s,O=%s";
Review Comment:
DISTINGUISHED_NAME_FORMAT is used by CSR client side to generate the DN for
in request.
DISTINGUISHED_NAME_WITH_SN_FORMAT is used by CSR server(SCM) side to
regenerate the DN.
Both of them are needed.
I have added some comments for that. Interesting they are not here. Let me
add them again in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
