ChenSammi commented on code in PR #5163:
URL: https://github.com/apache/ozone/pull/5163#discussion_r1361523569


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocol/SCMSecurityProtocol.java:
##########
@@ -87,7 +87,8 @@ String getSCMCertificate(ScmNodeDetailsProto scmNodeDetails,
    *                          certificate.
    */
   String getSCMCertificate(ScmNodeDetailsProto scmNodeDetails,
-      String certSignReq, boolean isRenew) throws IOException;
+      String certSignReq, boolean isRenew)

Review Comment:
   Will try to revert these unnecessary change. 



##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocol/SCMSecurityProtocol.java:
##########
@@ -87,7 +87,8 @@ String getSCMCertificate(ScmNodeDetailsProto scmNodeDetails,
    *                          certificate.
    */
   String getSCMCertificate(ScmNodeDetailsProto scmNodeDetails,
-      String certSignReq, boolean isRenew) throws IOException;
+      String certSignReq, boolean isRenew)

Review Comment:
   Will try to revert these unnecessary changes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to