adoroszlai commented on code in PR #5407:
URL: https://github.com/apache/ozone/pull/5407#discussion_r1361600826
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -108,7 +108,7 @@ public final class OzoneManagerDoubleBuffer {
private final boolean isTracingEnabled;
private final Semaphore unFlushedTransactions;
private final FlushNotifier flushNotifier;
- private final String threadPrefix;
+ private String threadPrefix = "";
Review Comment:
This should be left as it was, and we also need to keep the assignment in
the constructor. Defauilt value of `""` should be set on the corresponding
variable in the builder.
```suggestion
private final String threadPrefix;
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -128,7 +128,7 @@ public OzoneManagerStateMachine(OzoneManagerRatisServer
ratisServer,
ThreadFactory build = new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat(threadPrefix +
- "OM StateMachine ApplyTransaction Thread - %d").build();
+ "OM_StateMachine_ApplyTransaction_Thread - %d").build();
Review Comment:
```suggestion
"OMStateMachineApplyTransactionThread-%d").build();
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3246,7 +3246,7 @@ public boolean triggerRangerBGSync(boolean noWait) throws
IOException {
// Trigger Ranger BG Sync
if (noWait) {
final Thread t = new Thread(bgSync::triggerRangerSyncOnce,
- threadPrefix + "Trigger RangerSync");
+ threadPrefix + "Trigger_RangerSync");
Review Comment:
```suggestion
threadPrefix + "RangerSync");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
