sumitagrawl commented on code in PR #5407:
URL: https://github.com/apache/ozone/pull/5407#discussion_r1361783145
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -202,11 +210,11 @@ private OzoneManagerDoubleBuffer(OMMetadataManager
omMetadataManager,
OzoneManagerDoubleBufferMetrics.create();
this.indexToTerm = indexToTerm;
this.flushNotifier = flushNotifier;
-
+ this.threadPrefix = threadPrefix;
isRunning.set(true);
// Daemon thread which runs in background and flushes transactions to DB.
daemon = new Daemon(this::flushTransactions);
- daemon.setName("OMDoubleBufferFlushThread");
+ daemon.setName(threadPrefix + "OMDoubleBufferFlushThread");
Review Comment:
similar changes for OzoneDelegationTokenSecretManager is missing for daemon
being created
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/OpenKeyCleanupService.java:
##########
@@ -82,9 +82,11 @@ public class OpenKeyCleanupService extends BackgroundService
{
private final AtomicBoolean suspended;
public OpenKeyCleanupService(long interval, TimeUnit unit, long timeout,
- OzoneManager ozoneManager, ConfigurationSource conf) {
+ OzoneManager ozoneManager,
+ ConfigurationSource conf) {
super("OpenKeyCleanupService", interval, unit,
- OPEN_KEY_DELETING_CORE_POOL_SIZE, timeout);
+ OPEN_KEY_DELETING_CORE_POOL_SIZE, timeout,
+ ozoneManager.getNodeDetails().threadNamePrefix());
Review Comment:
similar changes is missing for
org.apache.hadoop.ozone.om.service.SnapshotDiffCleanupService#SnapshotDiffCleanupService
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -123,10 +124,11 @@ public OzoneManagerStateMachine(OzoneManagerRatisServer
ratisServer,
this.handler = new OzoneManagerRequestHandler(ozoneManager,
ozoneManagerDoubleBuffer);
-
+ this.threadPrefix = ozoneManager.getNodeDetails().threadNamePrefix();
ThreadFactory build = new ThreadFactoryBuilder().setDaemon(true)
- .setNameFormat("OM StateMachine ApplyTransaction Thread - %d").build();
+ .setNameFormat(threadPrefix +
+ "OMStateMachineApplyTransactionThread - %d").build();
this.executorService = HadoopExecutors.newSingleThreadExecutor(build);
Review Comment:
similar things required for installSnapshotExecutor also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
