sodonnel commented on code in PR #5459:
URL: https://github.com/apache/ozone/pull/5459#discussion_r1362609498


##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java:
##########
@@ -235,7 +235,13 @@ protected List<ChunkInfo> getChunkInfos() throws 
IOException {
                   .getLegacyFactor(pipeline.getReplicationConfig())))
           .build();
     }
-    acquireClient();
+    try {
+      acquireClient();
+    } catch (IOException ioe) {
+      LOG.warn("Failed to acquire client for pipeline " + pipeline +

Review Comment:
   Can we use the placeholder syntax "{}" in the log message rather than 
concatenation? Otherwise LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to