tanvipenumudy commented on PR #5391: URL: https://github.com/apache/ozone/pull/5391#issuecomment-1767855046
> SCM and OM may be over different node or access for SCM deployed path may not be accessible by OM, So IMO, just passing filename may not be enough. This is a valid point! The current ideation is to utilize this file for generating the `NetworkTopology` object [here](https://github.com/tanvipenumudy/ozone/commit/3bc5def0a2a3d1d98ba468cc9421524d9e7c62db#diff-54bbfc5b5dd89a4d035bee206c53d3d11bbb579a2957abca589e313283d98af9), which will be used to call `NetworkTopology#sortByDistanceCost` (in [KeyManagerImpl](https://github.com/tanvipenumudy/ozone/commit/3bc5def0a2a3d1d98ba468cc9421524d9e7c62db#diff-bde0dade7dd5ddda419499f4f999d25d40fcec1412e0ce809c36ffd1be473f22)) for performing sorting. I believe this can be solved using two different approaches: 1. Serving the loaded SCM schema file content (`NodeSchemaLoadResult` object) to OM instead of the SCM schema file config. > Please check how user update the conf and places the network topology file? can same be done at OM to simplify the solution? 2. As an alternative, a separate configuration can be introduced on the OM-side as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
