kerneltime commented on code in PR #5391:
URL: https://github.com/apache/ozone/pull/5391#discussion_r1364567355


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -335,6 +336,14 @@ public boolean addSCM(AddSCMRequest request) throws 
IOException {
     }
   }
 
+  @Override
+  public String getNetworkTopology() {
+    String schemaFile = conf.get(

Review Comment:
   We should serialize the file itself and send it or define a protobuf 
definition of the schema used in the file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to