adoroszlai commented on code in PR #5407:
URL: https://github.com/apache/ozone/pull/5407#discussion_r1363756899
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java:
##########
@@ -564,6 +564,9 @@ public synchronized void start(CertificateClient certClient)
throws IOException {
super.start(certClient);
tokenRemoverThread = new Daemon(new ExpiredTokenRemover());
+ tokenRemoverThread.setName(
+ ozoneManager.getThreadNamePrefix() +
+ "ExpiredTokenRemover");
tokenRemoverThread.start();
Review Comment:
It turns out `TestOzoneDelegationTokenSecretManager` is [timing
out](https://github.com/ArafatKhan2198/ozone/actions/runs/6558096841/job/17811358413#step:5:2247)
due to this change. It can be fxed by:
```diff
diff --git
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/OzoneSecretManager.java
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/OzoneSecretManager.java
index c99a13c489..601bdf0ea7 100644
---
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/OzoneSecretManager.java
+++
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/OzoneSecretManager.java
@@ -250,7 +250,7 @@ public Text getService() {
*
* @return true if secret mgr is running
*/
- public synchronized boolean isRunning() {
+ public boolean isRunning() {
return running;
}
```
I hope it doesn't trigger another findbugs problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
