errose28 commented on PR #4922: URL: https://github.com/apache/ozone/pull/4922#issuecomment-1773559048
LGTM. I think using OM service ID as the container owner makes sense. There's been a fair amount of discussion here, so I'll leave it open if others have further comments. Just one minor comment, in `OMKeyRequest#allocateBlock`, we can change the `omID` parameter name to `serviceID` to reflect the new usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
