hemantk-12 commented on code in PR #5476:
URL: https://github.com/apache/ozone/pull/5476#discussion_r1369653608
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java:
##########
@@ -470,4 +481,12 @@ protected void createKeyTest(boolean checkSuccess) throws
Exception {
}
}
+ protected void waitForLeaderToBeReady()
Review Comment:
nit: should we add it to `MiniOzoneHAClusterImpl` so that it could be used
by others?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java:
##########
@@ -202,7 +201,7 @@ public void testPrepareWithRestart() throws Exception {
// modified cluster.
shutdown();
init();
- setup();
+ initInstanceVariables();
Review Comment:
Why do we need to call `initInstanceVariables` here again if we are using
`@BeforeEach`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
