adoroszlai commented on code in PR #5476:
URL: https://github.com/apache/ozone/pull/5476#discussion_r1369703796
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java:
##########
@@ -202,7 +201,7 @@ public void testPrepareWithRestart() throws Exception {
// modified cluster.
shutdown();
init();
- setup();
+ initInstanceVariables();
Review Comment:
This was the old code:
```
// Create fresh cluster for this test to prevent timeout from restarting
// modified cluster.
shutdown();
init();
setup();
... (test)
```
Basically it re-runs `@AfterAll` and `@BeforeAll` manually for this test
case, but then does not call the `@BeforeEach` method (`initOM()`), rather only
a specific part of it (`setup()`). Normally the code in `@BeforeEach` stores
`cluster` etc. in instance variables, _and_ performs other steps. I guess we
want to avoid those other steps for this specific test case.
The only change in this test case is that `TestOzoneManagerPrepare.setup()`
was renamed to `initInstanceVariables()` because it conflicted with the new
`setup()` method from parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
