adoroszlai commented on code in PR #5519: URL: https://github.com/apache/ozone/pull/5519#discussion_r1377219803
########## hadoop-ozone/tools/pom.xml: ########## @@ -126,6 +126,12 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>junit-jupiter-params</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.springframework</groupId> + <artifactId>spring-core</artifactId> + <version>5.3.27</version> Review Comment: Version is defined here: https://github.com/apache/ozone/blob/f32e98bbe90fec4e72eb5b7050f173c73132919d/hadoop-ozone/pom.xml#L29 Also, _dependency_ check is failing: https://github.com/tanvipenumudy/ozone/actions/runs/6703292525/job/18214380212 ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/AbstractOmBucketReadWriteOps.java: ########## @@ -22,6 +22,7 @@ import org.apache.hadoop.ozone.OzoneConsts; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.springframework.util.unit.DataSize; Review Comment: Ozone already has `StorageSize` in `hdds-config` and `SizeInBytes` from Ratis. Can we use one of those instead of Spring? ########## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java: ########## @@ -146,10 +147,12 @@ enum FreonOps { @Option( names = {"--key-size", "--keySize"}, description = "Specifies the size of Key in bytes to be created. Full" + - " name --keySize will be removed in later versions.", - defaultValue = "10240" + " name --keySize will be removed in later versions. You can" + + " specify the size using data units like 'GB', 'MB', 'KB', etc.", + defaultValue = "10GB", Review Comment: Should be `10KB`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
