xichen01 commented on code in PR #5519:
URL: https://github.com/apache/ozone/pull/5519#discussion_r1393728525
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/AbstractOmBucketReadWriteOps.java:
##########
@@ -46,10 +47,12 @@ public abstract class AbstractOmBucketReadWriteOps extends
BaseFreonGenerator
LoggerFactory.getLogger(AbstractOmBucketReadWriteOps.class);
@Option(names = {"-g", "--size"},
- description = "Generated data size (in bytes) of each key/file to be " +
- "written.",
- defaultValue = "256")
- private long sizeInBytes;
+ description = "Generated data size of each key/file to be written. " +
+ "You can specify the size using data units like 'GB', 'MB', 'KB', " +
Review Comment:
Maybe a static `String` could be used to replace the repeated part of the
description, There are many descriptions that are similar.
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/AbstractOmBucketReadWriteOps.java:
##########
@@ -46,10 +47,12 @@ public abstract class AbstractOmBucketReadWriteOps extends
BaseFreonGenerator
LoggerFactory.getLogger(AbstractOmBucketReadWriteOps.class);
@Option(names = {"-g", "--size"},
- description = "Generated data size (in bytes) of each key/file to be " +
- "written.",
- defaultValue = "256")
- private long sizeInBytes;
+ description = "Generated data size of each key/file to be written. " +
+ "You can specify the size using data units like 'GB', 'MB', 'KB', " +
Review Comment:
We can add a description to indicate that `size` is base 2 binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
