adoroszlai commented on code in PR #5543:
URL: https://github.com/apache/ozone/pull/5543#discussion_r1381274656
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -76,13 +82,31 @@ public void importContainer(long containerID, Path
tarFilePath,
HddsVolume hddsVolume, CopyContainerCompression compression)
throws IOException {
- HddsVolume targetVolume = hddsVolume;
- if (targetVolume == null) {
- targetVolume = chooseNextVolume();
+ synchronized (this) {
Review Comment:
Both `importContainerProgress` and `containerSet` are now accessed/changed
under lock here, but without lock elsewhere. We should apply synchronization
consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
