sadanand48 commented on code in PR #5543:
URL: https://github.com/apache/ozone/pull/5543#discussion_r1382983755
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ContainerImporter.java:
##########
@@ -99,6 +123,9 @@ public void importContainer(long containerID, Path
tarFilePath,
containerSet.addContainer(container);
}
} finally {
+ synchronized (this) {
Review Comment:
how about using Collections.synchronizedSet() instead of two synchronized
blocks for addition & removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
