xBis7 opened a new pull request, #5553: URL: https://github.com/apache/ozone/pull/5553
## What changes were proposed in this pull request? `Last Heartbeat` in the Datanodes section in Recon's UI, is always showing NA because the `datanodeHeartbeatMap` in `ReconNodeManager` doesn't get updated. PR #4341, modified the `processHeartbeat()` method to also process the queue report as part of the heartbeat, by adding a `CommandQueueReport` parameter. [SCMDatanodeHeartbeatDispatcher.dispatch()](https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeHeartbeatDispatcher.java#L133-L134) is the only place where `processHeartbeat()` is used but it's only calling the overloaded method with the 3 parameters. Recon overrides the 2 parameter method and as a result, Recon's `processHeartbeat()` never gets called. The 2 parameter method is only used in tests and for that reason it has been cleaned up as part of this patch. This change is made as a second commit so that it can be easily reverted. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-9609 ## How was this patch tested? All existing tests were updated and are still passing. Green CIs on my fork: - https://github.com/xBis7/ozone/actions/runs/6769734433 - https://github.com/xBis7/ozone/actions/runs/6770026351 This patch was also tested manually and values are also updating as expected. Check attached screenshots. <img width="2041" alt="Screenshot 2023-11-06 at 16 32 13" src="https://github.com/apache/ozone/assets/74301312/149e2163-0006-4605-a27e-5ee3bf0e719f";> <img width="2044" alt="Screenshot 2023-11-06 at 16 33 34" src="https://github.com/apache/ozone/assets/74301312/8bf80a9a-edf0-4dce-8dcb-dd899cf0bead";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
