xBis7 commented on PR #5553: URL: https://github.com/apache/ozone/pull/5553#issuecomment-1798008807
> Would it not be good to have a 2 argument (excluding CommandQueueReport) method of processHeartBeat to avoid changes in all test methods because anyway you are passing null in all those tests and no test being performed for CommandQueueReport ? I wasn't so sure about this change either. I added the change as a second commit so that I can easily undo it. If we keep it, we have cleaner diffs. But because the PR that made the `CommandQueueReport` change, kept the old method around as a default, there was no error indicating that Recon needed to be updated as well. Action items - I will restore the 2 parameter method - Create a jira about fixing the tests - Add a TODO comment above the method, indicating that it's only used in tests and mentioning the jira @devmadhuu What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
