xichen01 commented on code in PR #5524:
URL: https://github.com/apache/ozone/pull/5524#discussion_r1383512460


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -289,6 +291,8 @@ public Response put(
           .equals(headers.getHeaderString("x-amz-content-sha256"))) {
         body = new DigestInputStream(new SignedChunksInputStream(body),
             E_TAG_PROVIDER.get());
+        length = Long.parseLong(
+            headers.getHeaderString(DECODED_CONTENT_LENGTH_HEADER));

Review Comment:
   Done.



##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -882,17 +895,28 @@ private Response createMultipartKey(OzoneVolume volume, 
String bucket,
               .createMultipartKey(ozoneBucket, key, length, partNumber,
                   uploadID, chunkSize, (DigestInputStream) body);
         }
-        ozoneOutputStream = getClientProtocol().createMultipartKey(
-            volume.getName(), bucket, key, length, partNumber, uploadID);
 
         if (copyHeader != null) {
           Pair<String, String> result = parseSourceHeader(copyHeader);
-
           String sourceBucket = result.getLeft();
           String sourceKey = result.getRight();
 
           OzoneKeyDetails sourceKeyDetails = getClientProtocol().getKeyDetails(
               volume.getName(), sourceBucket, sourceKey);
+          String range =
+              headers.getHeaderString(COPY_SOURCE_HEADER_RANGE);
+          if (range != null) {
+            RangeHeader rangeHeader =

Review Comment:
   Done.



##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -289,6 +291,8 @@ public Response put(
           .equals(headers.getHeaderString("x-amz-content-sha256"))) {
         body = new DigestInputStream(new SignedChunksInputStream(body),
             E_TAG_PROVIDER.get());
+        length = Long.parseLong(
+            headers.getHeaderString(DECODED_CONTENT_LENGTH_HEADER));

Review Comment:
   Done.



##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -882,17 +895,28 @@ private Response createMultipartKey(OzoneVolume volume, 
String bucket,
               .createMultipartKey(ozoneBucket, key, length, partNumber,
                   uploadID, chunkSize, (DigestInputStream) body);
         }
-        ozoneOutputStream = getClientProtocol().createMultipartKey(
-            volume.getName(), bucket, key, length, partNumber, uploadID);
 
         if (copyHeader != null) {
           Pair<String, String> result = parseSourceHeader(copyHeader);
-
           String sourceBucket = result.getLeft();
           String sourceKey = result.getRight();
 
           OzoneKeyDetails sourceKeyDetails = getClientProtocol().getKeyDetails(
               volume.getName(), sourceBucket, sourceKey);
+          String range =
+              headers.getHeaderString(COPY_SOURCE_HEADER_RANGE);
+          if (range != null) {
+            RangeHeader rangeHeader =

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to