guohao-rosicky commented on PR #5524: URL: https://github.com/apache/ozone/pull/5524#issuecomment-1798452448
Thanks @xichen01 working on this, I think it's a good change to just add `requiresAtomicWrite` to s3g and add an assertion on close, if there's an assertion error, it also goes into finally for cleanup and doesn't result in resource leakage. Elegant code and detailed testing, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
